fparser: init at 4.5.1 #84654
Merged
fparser: init at 4.5.1 #84654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Apr 7, 2020
| sha256 = "0wayml1mlyi922gp6am3fsidhzsilziksdn5kbnpcln01h8555ad"; | ||
| }; | ||
|
|
||
| buildInputs = [ cmake ]; |
There was a problem hiding this comment.
important for cross compilation
Suggested change
| buildInputs = [ cmake ]; | |
| nativeBuildInputs = [ cmake ]; |
|
|
||
| stdenv.mkDerivation rec { | ||
| pname = "fparser"; | ||
| version = "4.5.1"; |
There was a problem hiding this comment.
how is this determined? upstream doesn't have any releases
https://github.com/thliebig/fparser/releases
There was a problem hiding this comment.
It's buried a bit. See here.
There was a problem hiding this comment.
Should probably be 2015-09-25 since that's the date of the revision you're pinning to. I don't know if it needs an unstable- prefix -- @jonringer?
There was a problem hiding this comment.
if taking from a revision, the current pratice is take the commit date, so version = unstable-2015-09-25 in this case
|
Changes implemented. |
aanderse
requested changes
Apr 9, 2020
jonringer
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
LGTM
Result of nixpkgs-review pr 84654 1
9 packages marked as broken and skipped:
- clang-sierraHack - digitalbitbox - glibcCross - linuxPackages_4_4.evdi - linuxPackages_hardkernel_4_14.bpftrace - linuxPackages_hardkernel_4_14.can-isotp - linuxPackages_hardkernel_4_14.digimend - linuxPackages_hardkernel_4_14.evdi - python27Packages.caffe1 package built:
- fparser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Needed for CSXCAD support (see this PR).
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)