Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.FileMap and dep #84600

Closed
wants to merge 2 commits into from
Closed

perlPackages.FileMap and dep #84600

wants to merge 2 commits into from
+28 −0

Conversation

invokesus
Copy link
Contributor

@invokesus invokesus commented Apr 7, 2020 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@invokesus invokesus force-pushed the contrib/perl-filemap branch 2 times, most recently from a4ec97a to 414a772 Compare April 9, 2020 16:35
@invokesus
Copy link
Contributor Author

Thanks for the review! Amended and force-pushed.

@invokesus invokesus mentioned this pull request Apr 11, 2020
Merged
10 tasks
stigtsp
stigtsp approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update PerlIO::Layers to 0.012

LGTM

stigtsp
stigtsp reviewed Jul 6, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update File::Map to 0.67

@invokesus
Copy link
Contributor Author

Thanks for the review! Updated the versions and force-pushed.

@invokesus
Copy link
Contributor Author

Oh, I see it got added in 4e8a420. I'll close this then.

@invokesus invokesus closed this Sep 14, 2020
@invokesus invokesus deleted the contrib/perl-filemap branch September 14, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@invokesus @stigtsp