Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.monty: fix tests #84503

Merged
merged 1 commit into from Apr 7, 2020
Merged

python3Packages.monty: fix tests #84503

merged 1 commit into from Apr 7, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Apr 6, 2020 •
edited

Motivation for this change

noticed it was failing in #84463

upstreamed to:
materialsvirtuallab/monty#121

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
[12 built, 6 copied (14.5 MiB), 2.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/84503
1 package marked as broken and skipped:
python38Packages.sunpy

12 package built:
python37Packages.dftfit python37Packages.lammps-cython python37Packages.monty python37Packages.pymatgen python37Packages.pymatgen-lammps python37Packages.sumo python38Packages.dftfit python38Packages.lammps-cython python38Packages.monty python38Packages.pymatgen python38Packages.pymatgen-lammps python38Packages.sumo

@jonringer jonringer requested a review from FRidh as a code owner April 6, 2020 19:23
@jonringer
Copy link
Contributor Author 

[12 built, 6 copied (14.5 MiB), 2.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/84503
1 package marked as broken and skipped:
python38Packages.sunpy

12 package built:
python37Packages.dftfit python37Packages.lammps-cython python37Packages.monty python37Packages.pymatgen python37Packages.pymatgen-lammps python37Packages.sumo python38Packages.dftfit python38Packages.lammps-cython python38Packages.monty python38Packages.pymatgen python38Packages.pymatgen-lammps python38Packages.sumo

since editing my post isn't working

@ofborg ofborg bot requested a review from PsyanticY April 6, 2020 19:31
@jonringer jonringer merged commit 8c9f06e into NixOS:master Apr 7, 2020
@jonringer jonringer deleted the fix-monty branch April 7, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@PsyanticY PsyanticY Awaiting requested review from PsyanticY

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer