Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggling "Full animation" first glitches, then reduces vertical size #8067

Closed
tomstorey opened this issue Apr 7, 2020 · 2 comments
Closed

Toggling "Full animation" first glitches, then reduces vertical size #8067

tomstorey opened this issue Apr 7, 2020 · 2 comments
Labels
OS: MacOS This issue is related to a Mac OS problem

Comments

@tomstorey
Copy link

tomstorey commented Apr 7, 2020 •
edited

Version of OpenTTD

1.9.3

Expected result

None

Actual result

The first time "Full animation" is toggled (on to off), the vertical screen size reduces slightly and the top of the screen (ala menu bar) is duplicated.

Screen Shot 2020-04-07 at 12 33 39

Subsequently, each time "Full animation" is toggled on and off, the veritcal screen size is reduced slightly, this can be done until the game is an unplayable slither on the screen.

Prenfingpool Transport, 6th Feb 1954

Exiting and then re-entering full screen restores the full vertical size again.

Steps to reproduce

On Mac OS X, open game and go to full screen. Toggle "Full animation" repeatedly.
@andythenorth
Copy link
Contributor

Got a repro of this. 10.0 official binary. macOS 10.15.1 Catalina.

Happens in full-screen mode only. Cannot repro in windowed mode.

There was a previous incidence of this bug which was visible in windowed mode. I haven't looked yet if/how that was fixed, but I haven't seen that one happen for quite some time

@tomstorey
Copy link
Author

I wasn't able to repro in windowed mode either. Unfortunately I wasn't able to test 1.10.0 as it's not starting on my Mac (crash on start).

@glx22 glx22 added the OS: MacOS This issue is related to a Mac OS problem label Apr 7, 2020
@andythenorth andythenorth mentioned this issue Jan 3, 2021
Closed
michicc added a commit to michicc/OpenTTD that referenced this issue Jan 3, 2021
@michicc
Fix OpenTTD#8067: [OSX] Calculate title bar height instead of assumin…
93b797b 
…g a fixed value.
michicc added a commit to michicc/OpenTTD that referenced this issue Jan 3, 2021
@michicc
Revert 4ce53cb: [OSX] Delayed fullscreen switch is not needed anymore.
7e0b274 
The fix for OpenTTD#8067 solves the real issue, making this workaround unneeded.
@andythenorth andythenorth mentioned this issue Jan 3, 2021
Merged
@michicc michicc closed this as completed in 6e8be3b Jan 3, 2021
michicc added a commit that referenced this issue Jan 3, 2021
@michicc
Revert 4ce53cb: [OSX] Delayed fullscreen switch is not needed anymore.
979b4af 
The fix for #8067 solves the real issue, making this workaround unneeded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS: MacOS This issue is related to a Mac OS problem
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andythenorth @glx22 @tomstorey