jupp: 31 -> 39 #84538
Merged
jupp: 31 -> 39 #84538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
reviewed
Apr 7, 2020
| @@ -2,17 +2,18 @@ | |||
| , ncurses, gpm | |||
| }: | |||
|
|
|||
| with stdenv.lib; | |||
There was a problem hiding this comment.
Same comment as I made on your mksh PR: why was this moved? Doesn't seem necessary.
There was a problem hiding this comment.
It makes the stdenv.lib functions available to all expression, not only meta part.
There was a problem hiding this comment.
Yes, but there's no need for stdenv.lib to be available anywhere else but the meta block, AFAICS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)