Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave: 1.5.115 -> 1.5.123 #84536

Merged
merged 1 commit into from Apr 12, 2020
Merged

brave: 1.5.115 -> 1.5.123 #84536

merged 1 commit into from Apr 12, 2020

Conversation

JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Apr 7, 2020 •
edited

Update the checksum and the version of Brave package.

(cherry picked from commit 7a80ead)
Reason: Browsers must be kept up-to-date

Motivation for this change

Backport PR #84151

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JeffLabonte
brave: 1.5.115 -> 1.5.123
528b5b6 
Update the checksum and the version of Brave package.

(cherry picked from commit 7a80ead)
Reason: Browsers must be kept up-to-date
@ofborg ofborg bot requested review from rht and uskudnik April 7, 2020 02:33
@rht
Copy link
Member

rht commented Apr 7, 2020

LGTM

@marsam marsam merged commit 5fa2612 into NixOS:release-19.09 Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rht rht Awaiting requested review from rht

@uskudnik uskudnik Awaiting requested review from uskudnik

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JeffLabonte @rht @marsam