Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.fastapi: 0.49.0 -> 0.54.0 #84642

Merged
merged 2 commits into from Apr 7, 2020
Merged

python3Packages.fastapi: 0.49.0 -> 0.54.0 #84642

merged 2 commits into from Apr 7, 2020

Conversation

wd15
Copy link
Contributor

@wd15 wd15 commented Apr 7, 2020 •
edited by jonringer

Motivation for this change

Update Fastapi to work with lastest version of Starlette, see #84566

closes #84566

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wd15
Copy link
Contributor Author

wd15 commented Apr 7, 2020

Result of nixpkgs-review pr 84642 1

4 package built:
  • python37Packages.fastapi
  • python37Packages.starlette
  • python38Packages.fastapi
  • python38Packages.starlette

@wd15 wd15 changed the title [WIP] python37Packages.fastapi: 0.49.0 -> 0.54.0 [WIP] pythonPackages.fastapi: 0.49.0 -> 0.54.0 Apr 7, 2020
@wd15 wd15 changed the title [WIP] pythonPackages.fastapi: 0.49.0 -> 0.54.0 [WIP] python3Packages.fastapi: 0.49.0 -> 0.54.0 Apr 7, 2020
@wd15 wd15 changed the title [WIP] python3Packages.fastapi: 0.49.0 -> 0.54.0 python3Packages.fastapi: 0.49.0 -> 0.54.0 Apr 7, 2020
@wd15 wd15 mentioned this pull request Apr 7, 2020
Closed
@jonringer
Copy link
Contributor

when making a pr, you can say: closes #.. or fixes #... and it will automatically close the related issue/PR.

jonringer
jonringer approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/84642
4 package built:
python37Packages.fastapi python37Packages.starlette python38Packages.fastapi python38Packages.starlette

@jonringer jonringer merged commit ae1b83c into NixOS:master Apr 7, 2020
@wd15 wd15 deleted the fastapi-0.54.0 branch April 7, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wd15 @jonringer @r-ryantm