Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nipy ecosystem: quote homepage urls #84643

Merged
merged 4 commits into from Apr 9, 2020
Merged

Nipy ecosystem: quote homepage urls #84643

merged 4 commits into from Apr 9, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Apr 7, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin bcdarwin changed the title quote Nipy ecosystem urls Nipy ecosystem: quote homepage urls Apr 7, 2020
nlewo
nlewo requested changes Apr 9, 2020
View reviewed changes
Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are modifying the homepage, we could also remove trailing /.

pkgs/development/python-modules/nibabel/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/nipy/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/nipype/default.nix Show resolved Hide resolved
@bcdarwin bcdarwin requested a review from nlewo April 9, 2020 14:46
@nlewo nlewo merged commit 47daa68 into NixOS:master Apr 9, 2020
@bcdarwin bcdarwin deleted the nipy-ecosystem-urls branch April 9, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@nlewo nlewo Awaiting requested review from nlewo

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bcdarwin @nlewo