Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python2Packages.cryptography: add missing ipaddress dependency #84660

Merged
merged 1 commit into from Apr 8, 2020
Merged

python2Packages.cryptography: add missing ipaddress dependency #84660

merged 1 commit into from Apr 8, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Apr 7, 2020 •
edited

Motivation for this change

noticed it was broken when reviewing #84437

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner April 7, 2020 19:38
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python2Packages.cryptography

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.cryptography
@GrahamcOfBorg build python38Packages.cryptography

@ofborg ofborg bot requested a review from primeos April 7, 2020 19:50
@jonringer
Copy link
Contributor Author

this failure came up in another review, merging

@jonringer jonringer merged commit b3ef0f3 into NixOS:staging Apr 8, 2020
@jonringer jonringer deleted the fix-crypto-py2 branch April 8, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@primeos primeos Awaiting requested review from primeos

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer