Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python37Packages.starlette: 0.12.9 -> 0.13.2 #84566

Closed

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Apr 7, 2020

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-starlette/versions.

meta.description for python37Packages.starlette is: "The little ASGI framework that shines"

meta.homepage for python37Packages.starlette is: "https://www.starlette.io/"

Updates performed:

  • Version update
  • Quoted meta.homepage for RFC 45

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

16 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
4 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python37Packages.fastapi
python37Packages.starlette
python38Packages.fastapi
python38Packages.starlette

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/x3mfgbjp0fsh0xpsgwg1gpcv6nixv1wi-python3.7-starlette-0.13.2 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A python37Packages.starlette https://github.com/r-ryantm/nixpkgs/archive/782a198e7899e4fe22e0cddca619e5a9c701c400.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/x3mfgbjp0fsh0xpsgwg1gpcv6nixv1wi-python3.7-starlette-0.13.2
ls -la /nix/store/x3mfgbjp0fsh0xpsgwg1gpcv6nixv1wi-python3.7-starlette-0.13.2/bin

cc @wd15 for testing.

@wd15
Copy link
Contributor

wd15 commented Apr 7, 2020

This breaks Fastapi,

Result of nixpkgs-review pr 84566 1

2 package failed to build:
  • python37Packages.fastapi
  • python38Packages.fastapi
2 package built:
  • python37Packages.starlette
  • python38Packages.starlette

Starlette was reverted back to 0.12.9 in #84275 for this reason.

However, the latest version of Fastapi works with 0.13.2 of Starlette, so I'll make a PR for that soon.

@jonringer
Copy link
Contributor

I'll wait for your PR :)

@wd15
Copy link
Contributor

wd15 commented Apr 7, 2020

New PR, #84642, which includes this commit and fastapi update

@r-ryantm r-ryantm deleted the auto-update/python3.7-starlette branch April 8, 2020 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants