nixos/ssh: don't accept ssh-dss keys #84602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #33381 |
These have been deprecated long enough. I think this default was even made non-functional by 2337c75. But it's still a scary thing to see there. Fixes NixOS#33381.
Mic92
reviewed
Apr 7, 2020
zimbatm
approved these changes
Apr 8, 2020
Mic92
approved these changes
Apr 8, 2020
|
Since its broken in 20.03 due to the openssh update we can backport this change as well. |
Ma27
approved these changes
Apr 8, 2020
|
Maybe it's worth a line in release notes (once we're sure whether in 20.09 or 20.03). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have been deprecated long enough. I think this default was even
made non-functional by 2337c75. But
it's still a scary thing to see there.
cc @zimbatm @yorickvP