Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos: default nix.maxJobs to auto #84570

Merged
merged 1 commit into from Apr 8, 2020
Merged

nixos: default nix.maxJobs to auto #84570

merged 1 commit into from Apr 8, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 7, 2020

Instead of making the configuration less portable by hard coding the number of
jobs equal to the cores we can also let nix set the same number at runtime.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
nixos: default nix.maxJobs to auto
e6a15db 
Instead of making the configuration less portable by hard coding the number of
jobs equal to the cores we can also let nix set the same number at runtime.
@Mic92 Mic92 requested a review from edolstra April 7, 2020 07:55
@Mic92
Copy link
Member Author

Mic92 commented Apr 7, 2020

@GrahamcOfBorg test nixos-generate-config

@Ma27 Ma27 merged commit 2577ec2 into NixOS:master Apr 8, 2020
@Mic92 Mic92 deleted the max-jobs branch April 9, 2020 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @Ma27