Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

case-kak: init at unrelease-2020-04-06 #84526

Merged
merged 1 commit into from Aug 27, 2020
Merged

case-kak: init at unrelease-2020-04-06 #84526

merged 1 commit into from Aug 27, 2020

Conversation

eraserhd
Copy link
Contributor

@eraserhd eraserhd commented Apr 7, 2020

Motivation for this change

This plugin is useful, so package it. It converts words betweeen different cases
in the Kakoune editor (e.g. snake_case -> PascalCase).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    New package, +4984
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eraserhd
Copy link
Contributor Author

bump? This seems pretty uncontroversial.

@eraserhd
Copy link
Contributor Author

@matthewbauer @vrthra Want to check this out? It seems uncontroversial.

alyssais
alyssais requested changes Aug 16, 2020
View reviewed changes
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good. :)

pkgs/applications/editors/kakoune/plugins/case.kak.nix Show resolved Hide resolved
pkgs/applications/editors/kakoune/plugins/case.kak.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/kakoune/plugins/case.kak.nix Outdated Show resolved Hide resolved
@eraserhd
Copy link
Contributor Author

@alyssais all issues resolved. Thanks for reviewing (again!)

@alyssais
Copy link
Member

@GrahamcOfBorg build kakounePlugins.case-kak

@alyssais alyssais merged commit 6bdf265 into NixOS:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eraserhd @alyssais