plasma-5,kde,kde-frameworks: update #83435
Conversation
| @@ -13,7 +13,6 @@ mkDerivation { | |||
| ki18n kio glib gtk2 gtk3 karchive kcmutils kconfigwidgets kiconthemes | |||
| knewstuff gsettings-desktop-schemas | |||
| ]; | |||
| patches = [ ./patches/follow-symlinks.patch ./patches/gsettings.patch ]; | |||
There was a problem hiding this comment.
These patches are essential; where did they go?
| } | ||
| } | ||
| sourceFiles(scripts); | ||
| - |
There was a problem hiding this comment.
It is important that startkde doesn't contaminate the XDG_DATA_DIRS variable. Why is this removed?
| @@ -44,7 +44,7 @@ mkDerivation { | |||
|
|
|||
| patches = [ | |||
| ./0001-startkde.patch | |||
| ./0002-absolute-wallpaper-install-dir.patch | |||
| # ./0002-absolute-wallpaper-install-dir.patch #TODO(bachp): check if this is needed https://github.com/KDE/plasma-workspace/blob/Plasma/5.18/sddm-theme/theme.conf.cmake | |||
There was a problem hiding this comment.
This patch is needed to set the correct absolute path to the SDDM theme wallpaper.
| @@ -1,2 +1 @@ | |||
| kcmutils-follow-symlinks.patch | |||
| kcmutils-debug-module-loader.patch | |||
There was a problem hiding this comment.
This patch is important for us to get useful bug reports. Please leave it in place.
There was a problem hiding this comment.
If I recall correctly the files this was patching does no longer exists.
There was a problem hiding this comment.
We need to find out where that code went and apply the patch there. It may even have moved to a different library, unfortunately.
There was a problem hiding this comment.
I just tried to get things compiling so we know what to look at. But the patches are not very well documented so it's hared to tell why they are needed.
How is this normaly done?
|
Just closing this may seem a bit ungrateful - sorry if it seemed that way @bachp. Thanks for doing this but I suggest you help out on the linked PR instead. |
|
Sorry, I didn't see this one before. My result is mostly the same until now, but I am still working on re-adding all the patches. |
|
@peterhoeg No worries, I'm actually glad somebody more experienced takes over, I can look over their shoulders. |
Motivation for this change
This is still work in progress in case somebody else is interested in helping out.
Update Plasma, KDE frameworks and KDE Applications to the newest versions:
This is the first time I'm working with KDE packaging in NixOS so I'm not sure I did it right.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)