discourse: init at 2.4.1 #83438
discourse: init at 2.4.1 #83438
Conversation
| example = "forum.example.org"; | ||
| }; | ||
|
|
||
| package = mkOption { |
There was a problem hiding this comment.
Do you expect users to choose between packages? If not I'd drop the option, you can always use overlay.
There was a problem hiding this comment.
I think this could be handy to set a package with plugins at some point.
| }; | ||
|
|
||
| systemd.tmpfiles.rules = [ | ||
| "C ${dataDir} - ${user} - - ${cfg.package}/share/discourse" |
There was a problem hiding this comment.
Will upgrades work when old content is not overwritten by C?
There was a problem hiding this comment.
I'm not sure about this approach at all, might be better to do this in PreStart as well.
|
|
||
| # afterwards generate gemset.nix from repo checkout using | ||
| # $ nix-shell -p bundix | ||
| # $ bundix |
There was a problem hiding this comment.
Can these instructions be converted into shell script?:D
There was a problem hiding this comment.
this is no longer necessary, right?
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/package-services-for-schools-covidsupport/6335/20 |
|
@GrahamcOfBorg eval |
|
Hi. Thank you for working on this. I'm pretty familiar with Discourse, so I'll try to help out in whatever way I can. Did you consider the approach of managing their Docker container instead of packaging the internals? |
Thanks! I've did consider that but it feels like cheating and I think there's a considerable value to be able to deploy w/o Docker:
NixOS approach allows for better granularity as you can split each part into its own container or even build Docker containers. Upstream could benefit from this as well since it doesn't look that problematic apart from application data dir issues (as it is not designed to be installed in one place and run at some other state dir, which is not that hard to fix either I guess). |
|
@GrahamcOfBorg test discourse |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/package-services-for-schools-covidsupport/6335/1 |
|
Just to avoid duplicate work, and maybe find co-maintainers, a similar but older PR: #59981 |
|
Thanks, I was searching for this before and while working on it and only found references to IRC logs. Good that it contains few more details about the |
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
|
Still important. |
stale
bot
removed
the
2.status: stale
|
Very nice! |
Motivation for this change
Discourse NixOS support.
Things done
Packaged two main components - rails application and mail forwarding utility.
Rail application has one major problem - it cannot compile javascript assets -
assets:recompilefails onSIGTERMwhen trying to usemini_racer. Ping @zimbatm according to IRC logs.Assets compilation is now restricted to
cssonly. (Btw asset compilation needs database access which is why it is running inpreStart).The application also doesn't quite like running from other places than its root directory so we "abuse"
tmpfilesto create/var/lib/discoursewith all the files. I've tried to do this selectively but hit weird errors with rails loader.Only basic vhost locations are configured and might need improvements according to https://github.com/discourse/discourse/blob/master/config/nginx.sample.conf#L90
Things to do
mini_racer SIGTERM)nginxlocationsFormalities
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)