Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpv: fix cocoa backend #83437

Merged
merged 1 commit into from Mar 27, 2020
Merged

mpv: fix cocoa backend #83437

merged 1 commit into from Mar 27, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 26, 2020

Motivation for this change

See: mpv-player/mpv#7449

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam merged commit 13b9806 into NixOS:master Mar 27, 2020
@marsam marsam deleted the fix-mpv-darwin branch March 27, 2020 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@Ma27 Ma27 Awaiting requested review from Ma27

@fpletz fpletz Awaiting requested review from fpletz

@tadeokondrak tadeokondrak Awaiting requested review from tadeokondrak

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@marsam