Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

khronos-ocl-icd-loader: 6c03f8b -> 2020.03.13 #83441

Merged
merged 2 commits into from Mar 31, 2020
Merged

khronos-ocl-icd-loader: 6c03f8b -> 2020.03.13 #83441

merged 2 commits into from Mar 31, 2020

Conversation

lsix
Copy link
Member

@lsix lsix commented Mar 26, 2020 •
edited

Motivation for this change

Khronos group starts to use tags for release of those repositories:

Use those instead of a “arbitrary” tag in the repo history.

nix-review fails on few packages, but as far as I can tell, they are already failing on master:

$ nix-review wip
32 package marked as broken and skipped:
clang-sierraHack clfswm digitalbitbox gdata-sharp glibcCross linuxPackages_4_4.evdi linuxPackages_hardkernel_4_14.bcc linuxPackages_hardkernel_4_14.can-isotp linuxPackages_hardkernel_4_14.chipsec linuxPackages_hardkernel_4_14.digimend linuxPackages_hardkernel_4_14.evdi linuxPackages_hardkernel_4_14.mba6x_bl linuxPackages_hardkernel_4_14.prl-tools muslCross newlibCross octave-jit php72Packages-unit.php_excel php72Packages.php_excel php73Packages-unit.php_excel php73Packages.php_excel php74Packages-unit.couchbase php74Packages-unit.pcs php74Packages-unit.php_excel php74Packages.couchbase php74Packages.php_excel python27Packages.flitBuildHook python37Packages.nixpart python37Packages.notify python37Packages.pyblock python38Packages.nixpart python38Packages.notify uuagc

15 package failed to build:
airwave arrayfire computecpp computecpp-unwrapped ethash ethminer fluidasserts forge gscan2pdf luxcorerender mandelbulber opencl-info python37Packages.pymc3 python38Packages.pymc3 sasview

82 package built:
beignet blender ccextractor cgminer cl clblas clfft clinfo clmagma darktable driversi686Linux.beignet fahclient fmbt futhark gImageReader hashcat k2pdfopt khronos-ocl-icd-loader leela-zero lutris lutris-free ocl-icd ocrmypdf opencl-clhpp opencl-headers opensubdiv paperless paperwork pdfsandwich pipelight playonlinux pybitmessage python27Packages.Lasagne python27Packages.Theano python27Packages.TheanoWithCuda python27Packages.libgpuarray python27Packages.loo-py python27Packages.pyopencl python27Packages.pytesseract python27Packages.reikna python27Packages.sasmodels python27Packages.tesserocr python37Packages.Theano python37Packages.TheanoWithCuda python37Packages.libgpuarray python37Packages.loo-py python37Packages.paperwork-backend python37Packages.pyocr python37Packages.pyopencl python37Packages.pytesseract python37Packages.reikna python37Packages.sasmodels python37Packages.tesserocr python38Packages.Theano python38Packages.TheanoWithCuda python38Packages.libgpuarray python38Packages.loo-py python38Packages.paperwork-backend python38Packages.pyocr python38Packages.pyopencl python38Packages.pytesseract python38Packages.reikna python38Packages.sasmodels python38Packages.tesserocr qt-box-editor ripgrep-all scallion sdrangel sycl-info tesseract tesseract4 utsushi vobsub2srt waifu2x-converter-cpp wf-recorder wifite2 wine wineStaging wineWowPackages.full winetricks wings xmr-stak
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from davidtwco March 26, 2020 18:50
davidtwco
davidtwco approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nix-review output:

2 package marked as broken and skipped:
cpp_ethereum invoice2data

11 package failed to build:
arrayfire ethash ethminer fluidasserts forge luxcorerender mandelbulber opencl-info python37Packages.pymc3 python38Packages.pymc3 sasview

@Mic92 Mic92 merged commit 5112c97 into NixOS:master Mar 31, 2020
@jonringer jonringer mentioned this pull request Apr 10, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lsix @davidtwco @Mic92