Missing ClearNeedsStyleRecalc() for ::first-letter. #22479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 26, 2020
A FirstLetterPseudoElement is marked for style recalc when the text node the first letter belongs to is removed from the DOM tree. On the next style recalc, if the first-letter's originating element is inside a subtree marked for layout tree re-attachment, or one of its descendants are marked for re-attachment, we delay the first-letter style update until UpdateFirstLetterPseudoElement is called for the kRebuildLayoutTree or kAttachLayoutTree phases. For the former, we call RecalcStyle which will ClearNeedsStyleRecalc, but ofr the kAttachLayoutTree phase, we called StyleForLayoutObject without clearing the dirty flag. Bug: 1064595 Change-Id: Ibebb9c358b473f61b1cff49a7c5ec43bf6894408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122347 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#753806}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2122347
branch
from
ab55783
to
99237f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A FirstLetterPseudoElement is marked for style recalc when the text node
the first letter belongs to is removed from the DOM tree. On the next
style recalc, if the first-letter's originating element is inside a
subtree marked for layout tree re-attachment, or one of its descendants
are marked for re-attachment, we delay the first-letter style update
until UpdateFirstLetterPseudoElement is called for the
kRebuildLayoutTree or kAttachLayoutTree phases. For the former, we call
RecalcStyle which will ClearNeedsStyleRecalc, but ofr the
kAttachLayoutTree phase, we called StyleForLayoutObject without clearing
the dirty flag.
Bug: 1064595
Change-Id: Ibebb9c358b473f61b1cff49a7c5ec43bf6894408
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122347
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753806}