Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document SlackNotifications plugin #726

Merged
merged 3 commits into from Apr 1, 2020
Merged

Document SlackNotifications plugin #726

merged 3 commits into from Apr 1, 2020

Conversation

knl
Copy link
Contributor

@knl knl commented Mar 26, 2020

Apart from documenting the plugin and its options, add some print debug statements, to track how well the plugin is doing.

knl added 3 commits March 26, 2020 13:27
@knl
Add documentation for SlackNotification plugin
956f009
@knl
Refactor code
986fde8 
Extract the conditions before the loop, as they do not change due to channel
definition.
@knl
Add debug logging
1bee6e3 
This will help us track potential problems with the plugin.
@edolstra edolstra merged commit 9668bc0 into NixOS:master Apr 1, 2020
@edolstra
Copy link
Member

edolstra commented Apr 1, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knl @edolstra