Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/IndexedDB/keypath-exceptions.htm is disabled in Mozilla and WebKit #10793

Closed
zcorpan opened this issue May 2, 2018 · 7 comments
Closed

/IndexedDB/keypath-exceptions.htm is disabled in Mozilla and WebKit #10793

zcorpan opened this issue May 2, 2018 · 7 comments
Assignees
@inexorabletash
Labels
flaky

Comments

@zcorpan
Copy link
Member

zcorpan commented May 2, 2018

http://bocoup.github.io/wpt-disabled-tests-report/

Investigate what's up with this test:

Path Products Results Bugs
/IndexedDB/keypath-exceptions.htm mozilla webkit disabled: feature is incomplete [ Skip ] https://bugzilla.mozilla.org/show_bug.cgi?id=1404274 None
@zcorpan zcorpan added the flaky label May 2, 2018
@zcorpan zcorpan self-assigned this May 2, 2018
@zcorpan zcorpan mentioned this issue May 2, 2018
Open
12 tasks
@zcorpan
Copy link
Member Author

zcorpan commented May 9, 2018

@jeffcarp @bevis-tseng any idea how to fix this test?

@jeffcarp
Copy link
Contributor

jeffcarp commented May 9, 2018

Apologies, I don't think I can be of help here or for #10792. I know @inexorabletash and @pwnall work on IndexedDB and, if they have time, might be able to take a look to see why it's flaky.

@inexorabletash
Copy link
Contributor

Is it flaky or just disabled?

If flaky, if you can give me a couple logs (pass/fail) I can probably puzzle it out.

@zcorpan
Copy link
Member Author

zcorpan commented May 10, 2018

" disabled: feature is incomplete " for mozilla, and "skip" for webkit. But it seems nicer to have the tests fail if the feature is not supported so it doesn't need to be disabled. I haven't yet investigated this test, I can take a closer look next week.

@zcorpan zcorpan assigned inexorabletash and unassigned zcorpan Jun 21, 2018
@inexorabletash
Copy link
Contributor

In FF52 I get 3 pass / 3 fail, harness OK.

I'm not sure what's actionable on the test - should it just be enabled with failures in Moz?

@zcorpan
Copy link
Member Author

zcorpan commented Jun 21, 2018

That sounds reasonable if results are stable.

@inexorabletash
Copy link
Contributor

Deflaked in 0f6860b863dd90ea1580de7f11d0cd2872f1713c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inexorabletash inexorabletash

Labels
flaky
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zcorpan @inexorabletash @jeffcarp