WebOTP: Re-Add WPT from SMS Receiver API #22474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 26, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2121466
branch
from
90c822d
to
73be6f9
Compare
This change re-adds wpt tests[1] from the former API iteration, SMS Receiver API, to the new OTP Credential API version. They were once deleted here[2], when cleaning up the previous API interface. [1]https://chromium.googlesource.com/chromium/src/+/26d14ef58e85c3826d4ca5cc0607efc49300b993/third_party/blink/web_tests/external/wpt/sms/interceptor.https.html [2]https://chromium-review.googlesource.com/c/chromium/src/+/2097041 Change-Id: Ic1755c0a6fab4764bd3b0ab06c688f1cd4001d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121466 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#754258}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2121466
branch
from
73be6f9
to
495df31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change re-adds wpt tests[1] from the former API iteration,
SMS Receiver API, to the new OTP Credential API version.
They were once deleted here[2], when cleaning up the previous
API interface.
[1]https://chromium.googlesource.com/chromium/src/+/26d14ef58e85c3826d4ca5cc0607efc49300b993/third_party/blink/web_tests/external/wpt/sms/interceptor.https.html
[2]https://chromium-review.googlesource.com/c/chromium/src/+/2097041
Change-Id: Ic1755c0a6fab4764bd3b0ab06c688f1cd4001d3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121466
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754258}