Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37Packages.marshmallow-polyfield: 5.7 -> 5.9 #83448

Merged
merged 1 commit into from Mar 27, 2020
Merged

python37Packages.marshmallow-polyfield: 5.7 -> 5.9 #83448

merged 1 commit into from Mar 27, 2020

Conversation

drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Mar 26, 2020 •
edited

Motivation for this change

Bump version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip". Didn't find dependent pythonPackages.qiskit-terra, but that builds manually.
  • Tested execution of all binary files (usually in ./result/bin/) via pytest
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.marshmallow-polyfield python38Packages.marshmallow-polyfield
@GrahamcOfBorg build python37Packages.qiskit-terra python38Packages.qiskit-terra

@drewrisinger
Copy link
Contributor Author

nixpkgs-review pr 83448

https://github.com/NixOS/nixpkgs/pull/83448
5 package built:
python37Packages.marshmallow-polyfield python37Packages.qiskit-ibmq-provider python37Packages.qiskit-terra python38Packages.marshmallow-polyfield python38Packages.qiskit-terra

@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.qiskit-ibmq-provider
(uvloop not supported on python38, so python38.qiskit-ibmq-provider is no-go)

@FRidh FRidh merged commit d39abe9 into NixOS:master Mar 27, 2020
@drewrisinger drewrisinger deleted the dr-pr-python-marshmallow-polyfield-bump branch March 27, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewrisinger @FRidh