Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.argcomplete: 1.10.3 -> 1.11.1 #83413

Merged
merged 1 commit into from Mar 26, 2020
Merged

python3Packages.argcomplete: 1.10.3 -> 1.11.1 #83413

merged 1 commit into from Mar 26, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 26, 2020 •
edited

Motivation for this change

noticed it was out of date

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
[18 built, 245 copied (892.0 MiB), 69.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/83413
11 package built:
azure-cli cloud-custodian cloudmonkey linkchecker pubs python27Packages.argcomplete python37Packages.argcomplete python37Packages.knack python38Packages.argcomplete python38Packages.knack styx

@jonringer jonringer requested a review from FRidh as a code owner March 26, 2020 09:29
@ofborg ofborg bot requested a review from womfoo March 26, 2020 09:38
lsix
lsix reviewed Mar 26, 2020
View reviewed changes
Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a 1.11.1 version available, any particular reason not to use it?

pkgs/development/python-modules/argcomplete/default.nix Outdated Show resolved Hide resolved
@jonringer jonringer changed the title python3Packages.argcomplete: 1.10.3 -> 1.11.0 python3Packages.argcomplete: 1.10.3 -> 1.11.1 Mar 26, 2020
@lsix lsix merged commit 9d46dea into NixOS:master Mar 26, 2020
@jonringer jonringer deleted the bump-argcomplete branch March 27, 2020 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix lsix approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@womfoo womfoo Awaiting requested review from womfoo

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @lsix