Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.fritzconnection: 0.8.4 -> 1.2.1 #83451

Merged
merged 1 commit into from Mar 27, 2020

Conversation

Valodim
Copy link
Contributor

@Valodim Valodim commented Mar 26, 2020

Motivation for this change

The upstream package includes test in the build. Patched that out and informed upstream, should be possible to drop the prePatch then. See kbr/fritzconnection#39

Closes #83384

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Mar 27, 2020

@GrahamcOfBorg build pythonPackages.fritzconnection

@FRidh
Copy link
Member

FRidh commented Mar 27, 2020

@GrahamcOfBorg build python3Packages.fritzconnection

@FRidh FRidh merged commit e3ccc89 into NixOS:master Mar 27, 2020
@Valodim Valodim deleted the fritzconnection-1.2.1 branch May 1, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python3Packages.fritzconnection: fails to build on 20.03
2 participants