New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost17x: 1.7.1 -> 1.7.2 #83419
boost17x: 1.7.1 -> 1.7.2 #83419
Conversation
@GrahamcOfBorg build rippled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like at least rippled
has issues:
from /build/source/src/ripple/unity/soci_ripple.cpp:21:
include/boost/coroutine/asymmetric_coroutine.hpp:2388:1: note: 'boost::coroutines::end'
make[2]: *** [CMakeFiles/rippled.dir/build.make:375: CMakeFiles/rippled.dir/src/ripple/unity/soci_ripple.cpp.o] Error 1
Mind taking a look and running nixpkgs-review
to see if there are others?
Looks like nixpkgs-review is not a package in nix... so I ran
|
Yup that's it; it was renamed a while ago: On the current master of NixPkgs, either attribute works, e.g.
At any rate, can you check if |
no there is no update for rippled as of this moment. but i noticed that it makes use of boost which translates to boost16x not boost17x which I have added. Note... I'm trying right now to get it to use boost172 |
Inside the package, it just specifies rippled = callPackage ../servers/rippled {
boost = boost17x;
}; So it is getting updated here :) Using the unversioned name inside the |
Looks good; for the 2nd commit, can you amend the subject to:
EDIT: Actuall,y now I'm seeing this:
@GrahamcOfBorg build rippled-validator-keys-tool |
thanks @bhipple I'm still compiling different versions of rippled-validator-keys-tool to get a clean working build.... can you try a nixpkg-review pr 83419? I may have to stash my local changes to get a clean build |
The above output is from me running just that. BTW, you can run it yourself as well:
(There's no special maintainer permission on this; it's just a nix tool like any other.)
|
I get this... but I may say I have a very dirty local nixpkgs repo
|
the bot failed to build as well... I'll see what I can do... now I am in a middle of a huge switch so I have to wait for some compiling work |
I left untouched the rippled-validator-keys-tool package which still uses boost167, the update of that package will be in another PR (although i don't promise anything). This builds fine for me. let's see what the bot says. @GrahamcOfBorg build rippled-validator-keys-tool rippled Edit: It seems it still fails so I have to take care of rippled-validator-keys-tool within this PR. So it is a work in progress... |
It appears this PR was superseded by #84182 |
Motivation for this change
Updated boost libraries to its latest version
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)@peti