Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/hibernate: disable for platforms other than x86_64 #83425

Merged
merged 1 commit into from Mar 28, 2020
Merged

nixos/tests/hibernate: disable for platforms other than x86_64 #83425

merged 1 commit into from Mar 28, 2020

Conversation

KamilaBorowska
Copy link
Member

Due to 9pnet_virtio bugs, /nix is no longer available after hibernation. It happens to work on x86_64, but not on other platforms.

Motivation for this change

ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
Copy link
Member Author

@GrahamcOfBorg test hibernate

@KamilaBorowska KamilaBorowska force-pushed the mark-hibernation-test-as-broken-on-aarch branch from 9226f38 to 4c1193a Compare March 28, 2020 08:30
@KamilaBorowska
nixos/tests/hibernate: disable for platforms other than x86_64
d85fb28 
Due to 9pnet_virtio bugs, /nix is no longer available after
hibernation. It happens to work on x86_64, but not on other
platforms.
@KamilaBorowska KamilaBorowska force-pushed the mark-hibernation-test-as-broken-on-aarch branch from 4c1193a to d85fb28 Compare March 28, 2020 08:31
@worldofpeace worldofpeace merged commit b1bffdf into NixOS:master Mar 28, 2020
@worldofpeace
Copy link
Contributor

I think an issue would be a good idea also.

@worldofpeace
Copy link
Contributor

backported to 20.03 in 8f623fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KamilaBorowska @worldofpeace