Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack: 4.2.0 -> 4.4.0 #83452

Merged
merged 2 commits into from Mar 28, 2020
Merged

slack: 4.2.0 -> 4.4.0 #83452

merged 2 commits into from Mar 28, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Mar 26, 2020 •
edited

Motivation for this change
  • version update
  • 4.4.1 on Darwin
  • remove dark-theme, it's now included in the release
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member Author

prusnak commented Mar 26, 2020

@mmahut please test on linux and darwin

@mmahut mmahut self-assigned this Mar 27, 2020
@ofborg ofborg bot requested a review from mmahut March 27, 2020 09:20
prusnak and others added 2 commits March 27, 2020 14:45
@prusnak
slack: 4.2.0 -> 4.4.0
84d18ac 
* 4.4.1 on Darwin
* remove dark-theme, it's now included in the release
@mmahut @prusnak
slack-dark: alias to slack
9a43587
@globin globin merged commit d4f08ee into NixOS:master Mar 28, 2020
@prusnak prusnak deleted the slack branch March 28, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault lovesegfault approved these changes

@mmahut mmahut Awaiting requested review from mmahut

Assignees

@mmahut mmahut

Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prusnak @lovesegfault @mmahut @globin