Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gecko Bug 1611848] Properly suppress shadow dom / display: contents inside svg text. #22467

Merged
merged 1 commit into from Mar 27, 2020
Merged

[Gecko Bug 1611848] Properly suppress shadow dom / display: contents inside svg text. #22467

merged 1 commit into from Mar 27, 2020

Conversation

moz-wptsync-bot
Copy link
Collaborator

Returning null from FindSVGData just means "fall back to whatever display
specifies", and that's not great.

Differential Revision: https://phabricator.services.mozilla.com/D67706

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1611848
gecko-commit: 02c284defc4d5f8d9ed1c7c8363becdd93f4b291
gecko-integration-branch: autoland
gecko-reviewers: heycam

@emilio @moz-wptsync-bot
Properly suppress shadow dom / display: contents inside svg text.
fd98a01 
Returning null from FindSVGData just means "fall back to whatever display
specifies", and that's not great.

Differential Revision: https://phabricator.services.mozilla.com/D67706

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1611848
gecko-commit: 02c284defc4d5f8d9ed1c7c8363becdd93f4b291
gecko-integration-branch: autoland
gecko-reviewers: heycam
wpt-pr-bot
wpt-pr-bot approved these changes Mar 26, 2020
View reviewed changes
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Firefox project.

@jgraham jgraham merged commit 87b887c into master Mar 27, 2020
@jgraham jgraham deleted the gecko/1611848 branch March 27, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

Assignees
No one assigned
Labels
mozilla:gecko-sync svg wg-svg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@moz-wptsync-bot @wpt-pr-bot @jgraham @emilio