python37Packages.rope: 0.14.0 -> 0.16.0 #83019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you amend to add double-quotes (i.e. "") around the homepage? |
bcdarwin
force-pushed
the
update-python-rope
branch
from
bb23ec6
to
8e131cd
Compare
bcdarwin
force-pushed
the
update-python-rope
branch
from
8e131cd
to
c1c91ea
Compare
|
@drewrisinger -- done, and I've re-run |
drewrisinger
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
Diff looks good.
Builds locally with nixpkgs-review.
[15 built, 432 copied (2233.8 MiB), 447.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/83019
12 package built:
cq-editor nixpkgs-pytools python27Packages.pyls-isort python27Packages.python-language-server python27Packages.rope python37Packages.pyls-black python37Packages.pyls-isort python37Packages.pyls-mypy python37Packages.python-language-server python37Packages.rope spyder python37Packages.spyder_3
jonringer
approved these changes
Mar 26, 2020
There was a problem hiding this comment.
LGTM
https://github.com/NixOS/nixpkgs/pull/83019
12 package built:
cq-editor nixpkgs-pytools python27Packages.pyls-isort python27Packages.python-language-server python27Packages.rope python37Packages.pyls-black python37Packages.pyls-isort python37Packages.pyls-mypy python37Packages.python-language-server python37Packages.rope spyder python37Packages.spyder_3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Note:
ropeis broken with Python 3.8; I have disabled it until its next release in a separate PR (#83009).nixpkgs-reviewbuilds all Python 3.7 packages correctly but of course all Python 3.8 fails as well as previously broken packagepython27Packages.python-language-serverand its reverse deppython27Packages.pyls-isort.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)