New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.qiskit-aqua: init at 0.6.5 #83447
Conversation
@jonringer @FRidh at this point it's just #83306 & #80662 left to finish #78772. I could wrap up the rest of the qiskit fixes in one PR, there's no new packages at this point. That way I could also demonstrate via bot that they all build. Summary of remaining qiskit fixes (all done, just didn't want to keep spamming PRs):
|
798df9b
to
01a3401
Compare
@GrahamcOfBorg eval |
Update: builds clean via 2 package built: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit/PR should refer to python3Packages
"--ignore-glob=*qgan.py" | ||
]; | ||
disabledTests = [ | ||
# Disabled due to missing pyscf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If pyscf
can't be added to checkInputs
for some reason, probably worth noting. (Indeed, consider adding a comment explaining why it's removed from the dependencies?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried packaging pyscf in #78872, and myself & jonringer ended up deciding that it's being too difficult/ugly to package (issue mostly coming down to pyscf
tests being very slow, failures difficult to diagnose, and long list of disabled tests that is hard to maintain). I can add note to that effect in code.
01a3401
to
d283a0a
Compare
Looks fine to me, will try to build later. |
postPatch = '' | ||
# Make pyscf optional, can be included at runtime via pip shell | ||
substituteInPlace setup.py \ | ||
--replace "pyscf; sys_platform == 'linux' or (python_version < '3.8' and sys_platform != 'win32')" "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will that work at runtime? Imagine you're a user that just installed this package from nixpkgs and expects it to work. Will there be unexpected crashes? If so, we should patch in a proper error message explaining the situation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I'd be fine adding error message on import. Will try to patch in.
b7ff273
to
51770fd
Compare
Let's see if we can actually build it now via borg after #84124... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the aarch64 build is failing. Please restrict meta.platforms
to x86-linux.
Qiskit Aqua: An extensible library of quantum computing algorithms. This commit follows the new Qiskit scheme of breaking one large package into smaller packages (terra, aer, etc), and then having a single meta-package "qiskit" that comprises them.
Build was failing on ofborg on platforms.aarch64 due to missing muparserx library built for aarch64. Added notes about this issue & when build could be expanded.
51770fd
to
ab4336f
Compare
@GrahamcOfBorg build python37Packages.qiskit-aqua python38Packages.qiskit-aqua Traced failing build to |
Looks good, thanks! |
Motivation for this change
Qiskit Aqua: An extensible library of quantum computing algorithms.
This commit follows the new Qiskit scheme of breaking one large package
into smaller packages (terra, aer, etc), and then having a single
meta-package "qiskit" that comprises them.
Broken out of #78772.
Waiting on #83306 #80662 #83372 to pass, builds cleanly when they're cherry-picked.
python38Packages.qiskit-aqua
will be broken due to upstream brokenpython38Packages.scikit-build
(#83305 )I disabled a lot of tests here, but there's still some 900 that run. So it's pretty well-tested.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)