New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flashrom: switch to Meson build and update deps #80293
Conversation
cca144f
to
63e10b8
Compare
@GrahamcOfBorg build flashrom Testing the expanded platforms list. |
63e10b8
to
df53b93
Compare
@GrahamcOfBorg build flashrom ...and again now that I fixed the merge conflict Edit: oh, I guess I don't have privs for the macOS builders anyway, so someone else would have to test that. But the flashrom homepage claims to support macOS, at least. |
libflashrom should also now be suitable for upstream consumption by fwupd, cc @jtojnar. |
@GrahamcOfBorg build flashrom |
Does it build on aarch64 now? See #79906 (comment) Also the commit message should be fixed now that @r-ryantmʼs update was merged. |
df53b93
to
17088c1
Compare
Huh, didn't realize I was beaten by the bot; strange it was merged days ago considering the release was only tagged and announced today. Removed the pointless @GrahamcOfBorg build flashrom |
17088c1
to
3388643
Compare
yep, still broken. Added a link to the upstream issue to track it at least. |
|
We could disable {
mesonFlags = [
(lib.optional (!stdenv.isi686 && !stdenv.isx86_64) "-Dpciutils=false")
];
} That said, it's probably better to invest effort into fixing this upstream. |
Motivation for this change
New upstream release. Also switches to the Meson build system, and libftdi1 (which I am slowly trying to kill the older version of).
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)