mrtrix: init at 3.0_RC3_latest #80292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcdarwin
force-pushed
the
mrtrix
branch
2 times, most recently
from
34a3ea0
to
fcb8375
Compare
This package consists mostly of command-line tools, but there are also two qt5-based image viewers (`mrview` and `shview`). I have provided an option `withGui = true` to allow users to disable these viewers. They work on NixOS but unlikely to work out-of-the box on non-NixOS Linux (see NixOS#62169), but I've refrained from asserting that they shouldn't be built since a user might want to fiddle with runtime GL stuff. Some programs rely on FSL and/or ANTs backends; I have somewhat heavy-handedly wrapped all binaries to point to ANTs, while FSL is not available in Nix at the moment and has a non-commercial license so would be convenient to disable by default for Hydra builds.
|
Given the odd name of the version, can we be sure that the tag won't be replaced in the future? |
|
@lheckemann - fair point, but it hasn't been updated in a while and an RC4 is out (but they've labelled it broken/internal use only). I could change to use the commit instead? |
|
That does sound unlikely to change, so I'm fine with using this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add a package. (Note that the slightly strange-looking version is in fact a valid Git tag.)
This package consists mostly of command-line tools, but there are also two qt5-based image viewers (
mrviewandshview). I have provided an optionwithGui ? trueto allow users to disable these viewers (primarily in order to remove Qt from the closure). They work on NixOS but are unlikely to work out-of-the box on non-NixOS Linux (see #62169), but I've refrained fromasserting that they shouldn't be built since a user might want to fiddle with runtime GL stuff.Some programs rely on FSL and/or ANTs backends; I have somewhat heavy-handedly wrapped all binaries to point to ANTs, while FSL is not available in Nix at the moment and has a non-commercial license so would be convenient to disable by default for Hydra builds.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)