libreoffice: wrapper: add hunspell dirs to DICPATH #80353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 17, 2020
|
Please note that installing dictionaries using |
|
Maybe replace the TODO comment with a mention of «dictionaries are provided via DICPATH» for better discoverability? Not everything goes to NIX_PROFILES. |
mmilata
force-pushed
the
libreoffice-spellcheck-dicpath
branch
from
a82d1c4
to
7803c2a
Compare
|
Added a comment, let me know if you can think of better wording. Not sure whether it helps discoverability much, perhaps it's time to add LibreOffice section to NixOS manual? Then again, not everyone who uses nixpkgs uses NixOS ... |
LibreOffice doesn't know where to look for hunspell dictionaries on NixOS but we can use the DICPATH env var to point to them. Now spellchecking with system dictionaries works. Note that some of these dictionaries are built from LibreOffice repos - this is preferable to building them as part of LO as other applications can use them.
mmilata
force-pushed
the
libreoffice-spellcheck-dicpath
branch
from
7803c2a
to
c95bfd2
Compare
|
Technically speaking, we even have a Nixpkgs manual. Not everyone knows it exists, and right now the package-specific notes are in the wrong place #77555 … |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LibreOffice doesn't know where to look for hunspell dictionaries on NixOS but we can use the
DICPATHenv var to point to them. Now spellchecking with system dictionaries (nixpkgs.hunspellDicts.xx-yy) works.Note that some of these dictionaries are built from LibreOffice repos - this is preferable to building them as part of LO as other applications can use them.
Motivation for this change
Spellchecking with hunspell dictionaries doesn't work.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)