Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequoia: fix build by migrating off legacy fetchCargo implementation #80209

Merged
merged 1 commit into from Feb 15, 2020
Merged

sequoia: fix build by migrating off legacy fetchCargo implementation #80209

merged 1 commit into from Feb 15, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Feb 15, 2020

Currently broken; see #79975 for details. Would also be fixed by #80153
eventually, but since we want to upgrade either way we might as well do so now.

https://hydra.nixos.org/job/nixpkgs/trunk/sequoia.x86_64-linux

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
sequoia: fix build by migrating off legacy fetchCargo implementation
993719b 
Currently broken; see NixOS#79975 for details. Would also be fixed by NixOS#80153
eventually, but since we want to upgrade either way we might as well do so now.
@bhipple
Copy link
Contributor Author

bhipple commented Feb 15, 2020 •
edited

@GrahamcOfBorg build sequoia

@worldofpeace worldofpeace merged commit 8040b44 into NixOS:master Feb 15, 2020
@bhipple
Copy link
Contributor Author

bhipple commented Feb 15, 2020

Interesting. This built and passed all of test cases for me locally (using NixOS with sandboxing), and built for ofBorg, but appears to have just failed on Hydra . . . any ideas?

https://hydra.nixos.org/build/112870138

@doronbehar
Copy link
Contributor

It's the same old #70646 .

@bhipple
Copy link
Contributor Author

bhipple commented Feb 15, 2020

Ah, so I'm guessing it'll build eventually? This package did take a looooooooong time to compile and run its test cases on my laptop -- long enough that I went and spun up a 48 core build box on AWS instead :)

@bhipple bhipple deleted the u/rust-cargo-sequoia branch June 2, 2020 22:13
@puzzlewolf puzzlewolf mentioned this pull request Jun 16, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar Awaiting requested review from doronbehar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @doronbehar @worldofpeace