Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-make: update to new cargo fetcher and fix runCommand #80248

Closed
wants to merge 1 commit into from
Closed

cargo-make: update to new cargo fetcher and fix runCommand #80248

wants to merge 1 commit into from

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Feb 16, 2020

General upgrade as part of #79975; also requires changing the name of the
runCommand to source, so that it creates a standard source directory that
the cargo lockfile verification expects.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
cargo-make: update to new cargo fetcher and fix runCommand
39bef25 
General upgrade as part of NixOS#79975; also requires changing the name of the
runCommand to `source`, so that it creates a standard `source` directory that
the cargo lockfile verification expects.
@bhipple
Copy link
Contributor Author

bhipple commented Feb 16, 2020

@GrahamcOfBorg build cargo-make

@bhipple
Copy link
Contributor Author

bhipple commented Feb 16, 2020

I have a more generic fix coming for this that'll let us avoid this source patching dance here.

@bhipple bhipple closed this Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bhipple