Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

synergy: Build application bundle on Darwin + other fixes #80354

Merged
merged 1 commit into from Feb 17, 2020
Merged

synergy: Build application bundle on Darwin + other fixes #80354

merged 1 commit into from Feb 17, 2020

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Feb 17, 2020

Motivation for this change

Includes the following fixes for Darwin:

  • Build an application bundle
  • Don't install the .desktop file and icons
  • Get rid of unused cmake variables
  • Don't list avahi as a dependency, since it's not used

I've noticed that MacOS Catalina prompts the user to grant accessibility permissions for bash rather than the ´synergy´ binary that the wrapper script execs. I'm guessing this is a bug in MacOS - but I only found one other report of this (debauchee/barrier#475 (comment))

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talyz
synergy: Build application bundle on Darwin + other fixes
9b29f1b 
Includes the following fixes for Darwin:
- Build an application bundle
- Don't install the .desktop file and icons
- Get rid of unused cmake variables
- Don't list avahi as a dependency, since it's not used
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 17, 2020
@talyz
Copy link
Contributor Author

talyz commented Feb 17, 2020

@GrahamcOfBorg build synergy synergyWithoutGUI

@ofborg ofborg bot requested a review from aszlig February 17, 2020 14:32
@benley
Copy link
Member

benley commented Feb 17, 2020

I can't actually test this as I don't have a Mac handy, but it looks like it's probably going to work so sure, let's merge it

@benley benley merged commit a2f3ec7 into NixOS:master Feb 17, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 18, 2020
@talyz @dtzWill
synergy: Build application bundle on Darwin + other fixes (NixOS#80354)
59250a6 
Includes the following fixes for Darwin:
- Build an application bundle
- Don't install the .desktop file and icons
- Get rid of unused cmake variables
- Don't list avahi as a dependency, since it's not used

(cherry picked from commit a2f3ec7)
@talyz talyz deleted the synergy-darwin-fixes branch February 19, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais Awaiting requested review from alyssais

@benley benley Awaiting requested review from benley

@aszlig aszlig Awaiting requested review from aszlig

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@talyz @benley