Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: industry vars 0x70 and 0x71 #84

Merged
merged 2 commits into from Feb 17, 2020

Conversation

andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Feb 16, 2020

Addresses #83
NML support for OpenTTD/OpenTTD@02b2b7b

Copy link
Contributor

@planetmaker planetmaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are production_rate_1 and _2 obsolete with that commit?
Or is it simply a cleanup mixed into the addition?

@andythenorth
Copy link
Contributor Author

Why are production_rate_1 and _2 obsolete with that commit?
Or is it simply a cleanup mixed into the addition?

I misread the previous commit for vars 0x69..0x6F 417e86e

I thought that also removed the old vars, but they're in a separate 'Remove' commit ff89170

I'll split them, should be 2 commits 1 PR imo.

…(0x8F) are deprecated and replaced by new parametric var production_rate (0x70)
Copy link
Contributor

@planetmaker planetmaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it's an omission from 16-cargo introduction which removes the old variables in a separate commit.

@planetmaker planetmaker merged commit 6b4472c into OpenTTD:master Feb 17, 2020
FLHerne added a commit to FLHerne/nml that referenced this pull request May 8, 2020
…0..100.

This was overlooked when it was added in PR OpenTTD#84.
FLHerne added a commit that referenced this pull request May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants