Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steamPackages.chrootenv: add file command #80320

Merged
merged 1 commit into from Feb 20, 2020
Merged

steamPackages.chrootenv: add file command #80320

merged 1 commit into from Feb 20, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 16, 2020 •
edited

Motivation for this change

I was using strace to figure out why a game wouldn't boot (turned out it just took a long while). But noticed in the strace logs that it was trying to call out to file and zenity.

NixOS steam sometimes has different behaviors than distro's, and I think this gets closer to the other distro's

commit body:

Noticed that the setup.sh for steam was trying to call these commands.
I'm not sure what the ramifications are for these missing,
but some steam features are quietly disabled when they
don't follow happy paths.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
steamPackages.chrootenv: add file command
a7abb6a 
Noticed that the setup.sh for steam was trying to call the file command.
I'm not sure what the ramifications are for these missing,
but some steam features are quietly disabled when they
don't follow happy paths.
@jonringer
Copy link
Contributor Author

zenity was adding around 20MB, where as file was only adding 6. The file command was the one which was being spammed 10's of times.

# steamon master
$ nix path-info -S ./result
/nix/store/4bdzl1ccxx3zpfgj1940s30y0biaa8yf-steam	 2213163920
# file + zenity
$ nix path-info -S ./result
/nix/store/jl0l978dwza68j60k4q0xy4v6wq08ly1-steam	 2230741224
# file only
$ nix path-info -S ./result
/nix/store/cq6ckaw6qkfmvmiax60x7hzyfvlnfp8g-steam	 2219241680

@jonringer jonringer changed the title steamPackages.chrootenv: add file and zenity helpers steamPackages.chrootenv: add file command Feb 18, 2020
@jonringer
Copy link
Contributor Author

tested this at home, should be a slight QoL improvement for some.

@jonringer jonringer merged commit 9cd683c into NixOS:master Feb 20, 2020
@jonringer jonringer deleted the steam-runtime-enhance branch February 20, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer