Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expect: use postPatch for stty patch #80319

Merged
merged 1 commit into from Feb 17, 2020
Merged

expect: use postPatch for stty patch #80319

merged 1 commit into from Feb 17, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 16, 2020 •
edited

Motivation for this change

follow up to: #80006 (comment)

postPatch is the "more appropriate" phase to use, but either phase has the desired effect.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author 

[13 built, 4 copied (39.8 MiB), 7.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80319
9 package built:
deepin.dde-file-manager deepin.deepin-terminal deepin.startdde dejagnu expect monotone profanity reposurgeon viking

@jonringer jonringer merged commit 46a93a7 into NixOS:master Feb 17, 2020
@jonringer jonringer deleted the expect-post-patch branch February 17, 2020 02:39
@grahamc grahamc mentioned this pull request Feb 24, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @jtojnar