Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 338e1dc57d5a
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 0591e947571c
Choose a head ref
  • 2 commits
  • 6 files changed
  • 1 contributor

Commits on Feb 17, 2020

  1. kinit: Increase environment size limit 

    start_kdeinit reads its environment over a pipe from start_kdeinit_wrapper. For
security, each environment entry must be smaller than 4kb by default. Qt-based
applications in Nixpkgs may have larger environments, and the recent upgrade to
Plasma 5.17 pushed start_kdeinit_wrapper over the limit. The limit is now
extended to 16kb.

This problem was not detected during testing because the failure is silent:
start_kdeinit will continue with an empty environment. In other circumstances,
this strategy might work, but it does not work on NixOS. This failure is now
treated as a fatal error.

Fixes: #79707
    @ttuegel
    ttuegel committed Feb 17, 2020
    Copy the full SHA
    c758609 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #80356 from ttuegel/bug--kinit-environ-size 

    kinit: Increase environment size limit
    @ttuegel
    ttuegel committed Feb 17, 2020
    Copy the full SHA
    0591e94 View commit details
    Browse the repository at this point in the history