Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pysam: 0.15.3 -> 0.15.4 #80360

Closed
wants to merge 1 commit into from
Closed

pysam: 0.15.3 -> 0.15.4 #80360

wants to merge 1 commit into from

Conversation

unode
Copy link
Member

@unode unode commented Feb 17, 2020 •
edited

Motivation for this change

Version 0.15.4 fixes a couple of segfaults and cython compatibility issues.
See also: #79548

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@unode unode mentioned this pull request Feb 17, 2020
Closed
@unode
Copy link
Member Author

unode commented Feb 17, 2020

@ofborg build python37Packages.pysam

@unode
Copy link
Member Author

unode commented Feb 17, 2020

Somewhat surprising that this builds fine on my current system (not NixOS) but fails here.
Closing this for now. Discussion ongoing at #79548

@unode unode closed this Feb 17, 2020
@unode unode mentioned this pull request Feb 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@unode