Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos: add /share/hunspell to environment.pathsToLink #80329

Merged
merged 1 commit into from Feb 27, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Feb 17, 2020

Motivation for this change

So that applications can find hunspell dictionaries installed through environment.systemPackages.

Please note that some desktop environments (lumina, mate, pantheon, plasma, lxqt, gnome3) add "/share" to environment.pathsToLink so this already accidentally works when such desktop is configured.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

So that applications can find hunspell dictionaries installed through
environment.systemPackages.
@JohnAZoidberg
Copy link
Member

Great, thanks!

@JohnAZoidberg JohnAZoidberg merged commit 39ed5ff into NixOS:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants