Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Avoid copying function parameters by using const references #8007

Merged
merged 1 commit into from Feb 17, 2020

Conversation

Quipyowert2
Copy link
Contributor

This fixes some more Cppcheck warnings. Although these warnings are reported as "performance" category warnings, I'm not sure this will speed the game up that much. At least this prevents the class instances passed as arguments from being copied.

[company_cmd.cpp:211]: (performance) Function parameter 'cost' should be passed by const reference.
[company_cmd.cpp:240]: (performance) Function parameter 'cost' should be passed by const reference.
[company_cmd.cpp:251]: (performance) Function parameter 'cst' should be passed by const reference.
[ai\ai_gui.cpp:592]: (performance) Function parameter 'config_item' should be passed by const reference. 

@Quipyowert2
Copy link
Contributor Author

Force pushed to update the function declarations of SubtractMoneyFromCompany and SubtractMoneyFromCompanyFract. Forgetting to make the declarations match the definitions caused unresolved external symbol errors on the CI build. I didn't find the function declaration for SubtractMoneyFromAnyCompany, however.

@nielsmh nielsmh merged commit 4552b17 into OpenTTD:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants