Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssb-patchbay: init at 8.1.0 #80359

Closed
wants to merge 1 commit into from
Closed

ssb-patchbay: init at 8.1.0 #80359

wants to merge 1 commit into from

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Feb 17, 2020

Packaged using ssb-patchwork as a template.

Motivation for this change

There was a request for a patchbay package. I haven't added myself as a maintainer as I probably won't be using this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Mentions to the Patchwork maintainers and a few others: @astro @flokli @ninjatrappeur @thedavidmeister @wakest
#53156

@ehmry
ssb-patchbay: init at 8.1.0
873cb4e 
Packaged using ssb-patchwork as a template.
@ehmry
Copy link
Contributor Author

ehmry commented Feb 17, 2020

@GrahamcOfBorg build ssb-patchbay

@picnoir
Copy link
Member

picnoir commented Feb 17, 2020 •
edited

I'm personally not using patchbay but would love to see this merged provided somebody is willing to take ownership of this package.

cc @asymmetric

@asymmetric
Copy link
Contributor

@NinjaTrappeur I'm using Patchwork atm, so have to pass :)

@asymmetric
Copy link
Contributor

Tried this out, it shows a segfault but then the app works well? 🤷‍♂️

[nix-shell:~/.cache/nixpkgs-review/pr-80359-2]$ results/ssb-patchbay/bin/ssb-patchbay
/nix/store/ff13hdsccj1cic0a64x21sdkp54gzarf-ssb-patchbay-extracted/AppRun: line 101: 10384 Segmentation fault      (core dumped) pidof appimaged 2> /dev/null
Fontconfig warning: "/etc/fonts/fonts.conf", line 86: unknown element "blank"
# AHOY: (main)     starting UI
friends hops: 2
# AHOY: (ui)       SENDING  >> ahoy:step
# AHOY: (main)     clearing UI
# ---------------
# AHOY: (main)     starting Server
# AHOY: (main)     starting UI
ssb-friends: stream legacy api used
STARTING Patchbay UI

@flokli
Copy link
Contributor

flokli commented Feb 18, 2020

Even when this wouldn't segfault, I don't think we should add new packages without a maintainer.

@ehmry ehmry closed this Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ehmry @picnoir @asymmetric @flokli