Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-outdated: 0.9.1 -> 0.9.5 #80294

Merged
merged 1 commit into from Feb 17, 2020
Merged

cargo-outdated: 0.9.1 -> 0.9.5 #80294

merged 1 commit into from Feb 17, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Feb 16, 2020

Upstream is now vendoring the Cargo.lock file for reproducible app builds, so we
can now remove the patching workaround. However, they're missing a git tag, so
we have to do some work to find the right git commit.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
cargo-outdated: 0.9.1 -> 0.9.5
66e5cc0 
Upstream is now vendoring the Cargo.lock file for reproducible app builds, so we
can now remove the patching workaround. However, they're missing a git tag, so
we have to do some work to find the right git commit.
@bhipple
Copy link
Contributor Author

bhipple commented Feb 16, 2020

@GrahamcOfBorg build cargo-outdated

@bhipple bhipple requested review from ivan and sondr3 February 16, 2020 20:19
sondr3
sondr3 approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@sondr3 sondr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built fine locally, LGTM.

@Ma27 Ma27 merged commit badcdb3 into NixOS:master Feb 17, 2020
@bhipple bhipple deleted the u/cargo-outdated branch June 2, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 left review comments

@sondr3 sondr3 sondr3 approved these changes

@ivan ivan Awaiting requested review from ivan

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @sondr3 @Ma27