docker-containers: Move ExecStartPre/ExecStopPost to preStart/postStop #80204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This fixes #76620.
docker-containers
usesserviceConfig.ExecStartPre
andserviceConfig.ExecStopPost
to cleanup containers. These options do not compose, so it is not possible to add additional commands here (e.g. to fetch secrets or run additional cleanup tasks).Note that the additional
|| true
replaces the-
prefix in the original values, which causes systemd to ignore the exit code.As far as I can tell, this PR does not interfere with #77479, #74378 or #76479 but it has a conflict (easy to fix) with #63241.
Things done
This changes only the resulting systemd unit file by adding one layer of indirection (as it moves the
ExecStartPre
andExecStopPost
commands into a standalone script), so it should not break anything.sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)