Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ripgrep-all: upgrade cargo fetcher implementation and cargoSha256 #80203

Merged
merged 1 commit into from Feb 15, 2020
Merged

ripgrep-all: upgrade cargo fetcher implementation and cargoSha256 #80203

merged 1 commit into from Feb 15, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Feb 15, 2020

Infra upgrade as part of #79975; no functional change expected.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
ripgrep-all: upgrade cargo fetcher implementation and cargoSha256
edee7de 
Infra upgrade as part of NixOS#79975; no functional change expected.
@bhipple
Copy link
Contributor Author

bhipple commented Feb 15, 2020

@GrahamcOfBorg build ripgrep-all

@ofborg ofborg bot requested review from zaninime and Ma27 February 15, 2020 21:08
@zaninime
Copy link
Contributor

Tested and it works normally.

@worldofpeace worldofpeace merged commit a168578 into NixOS:master Feb 15, 2020
@bhipple bhipple deleted the u/fix-ripgrep-all branch June 2, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaninime zaninime zaninime approved these changes

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @zaninime @worldofpeace