Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

symlinkJoin: fix "bash: Argument list too long" error #80348

Merged
merged 1 commit into from Feb 17, 2020
Merged

symlinkJoin: fix "bash: Argument list too long" error #80348

merged 1 commit into from Feb 17, 2020

Conversation

basvandijk
Copy link
Member

@basvandijk basvandijk commented Feb 17, 2020 •
edited

Motivation for this change

When the paths argument is too big symlinkJoin will fail with:

while setting up the build environment: executing '/nix/store/rm1hz1lybxangc8sdl7xvzs5dcvigvf7-bash-4.4-p23/bin/bash': Argument list too long
Things done

This is fixed by passing paths as a file instead of as an environment variable.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@basvandijk
symlinkJoin: fix "bash: Argument list too long" error
4e0a6bc 
When the `paths` argument is too big `symlinkJoin` will fail with:

```
while setting up the build environment: executing '/nix/store/rm1hz1lybxangc8sdl7xvzs5dcvigvf7-bash-4.4-p23/bin/bash': Argument list too long
```

This is fixed by passing `paths` as a file instead of as an
environment variable.
@basvandijk
Copy link
Member Author

basvandijk commented Feb 17, 2020 •
edited

The NixOS boot test is using symlinkJoin so let's test it:

@GrahamcOfBorg test boot

@basvandijk basvandijk mentioned this pull request Feb 17, 2020
Merged
@infinisil infinisil merged commit cf2a8ac into NixOS:master Feb 17, 2020
@basvandijk basvandijk mentioned this pull request Feb 18, 2020
Closed
10 tasks
This was referenced Jan 23, 2022
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@basvandijk @infinisil