Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unscii: cleanup and split outputs #80350

Merged
merged 1 commit into from Feb 18, 2020
Merged

unscii: cleanup and split outputs #80350

merged 1 commit into from Feb 18, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Feb 17, 2020

Motivation for this change

The font is very large and duplicated across many formats, some of which cannot be compressed, like .hex or .svg. For normal use (eg. X11, GTK applications) these formats are not necessary, so I propose to moved them to another output, reducing the default closure size.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested fonts with xfontsel and pango-view
  • Tested compilation of all pkgs that depend on this change (unscii)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The font is very large and duplicated across many formats, some of
which cannot be compressed, like `.hex` or `.svg`.
For normal use (eg. X11, GTK applications) these formats are not
necessary, so they are moved to another output reducing the default
closure size.
@rnhmjoj rnhmjoj merged commit 9244211 into NixOS:master Feb 18, 2020
@rnhmjoj rnhmjoj deleted the unscii branch April 7, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants