[WIP] Import migen's genlib.misc into nmigen.compat #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
=========================================
- Coverage 82.47% 82.18% -0.3%
=========================================
Files 35 35
Lines 5884 5782 -102
Branches 1193 1190 -3
=========================================
- Hits 4853 4752 -101
Misses 872 872
+ Partials 159 158 -1
Continue to review full report at Codecov.
|
Temporary, while we figure out how to handle them. Should save others from having to reverse-engineer them.
awygle
changed the title
|
Need to figure out whether to add corresponding functionality to nmigen, and add depreciation warnings, for all items in genlib.misc. |
|
I'm gonna chop this up into much smaller bits at some point, this seems unlikely to be mergeable as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.